Exercism v3 launches on Sept 1st 2021. Learn more! ๐Ÿš€๐Ÿš€๐Ÿš€
Avatar of rootulp

rootulp's solution

to Triangle in the Python Track

Published at Jul 13 2018 · 0 comments
Instructions
Test suite
Solution

Note:

This solution was written on an old version of Exercism. The tests below might not correspond to the solution code, and the exercise may have changed since this code was written.

Determine if a triangle is equilateral, isosceles, or scalene.

An equilateral triangle has all three sides the same length.

An isosceles triangle has at least two sides the same length. (It is sometimes specified as having exactly two sides the same length, but for the purposes of this exercise we'll say at least two.)

A scalene triangle has all sides of different lengths.

Note

For a shape to be a triangle at all, all sides have to be of length > 0, and the sum of the lengths of any two sides must be greater than or equal to the length of the third side. See Triangle Inequality.

Dig Deeper

The case where the sum of the lengths of two sides equals that of the third is known as a degenerate triangle - it has zero area and looks like a single line. Feel free to add your own code/tests to check for degenerate triangles.

Exception messages

Sometimes it is necessary to raise an exception. When you do this, you should include a meaningful error message to indicate what the source of the error is. This makes your code more readable and helps significantly with debugging. Not every exercise will require you to raise an exception, but for those that do, the tests will only pass if you include a message.

To raise a message with an exception, just write it as an argument to the exception type. For example, instead of raise Exception, you should write:

raise Exception("Meaningful message indicating the source of the error")

Running the tests

To run the tests, run the appropriate command below (why they are different):

  • Python 2.7: py.test triangle_test.py
  • Python 3.4+: pytest triangle_test.py

Alternatively, you can tell Python to run the pytest module (allowing the same command to be used regardless of Python version): python -m pytest triangle_test.py

Common pytest options

  • -v : enable verbose output
  • -x : stop running tests on first failure
  • --ff : run failures from previous test before running other test cases

For other options, see python -m pytest -h

Submitting Exercises

Note that, when trying to submit an exercise, make sure the solution is in the $EXERCISM_WORKSPACE/python/triangle directory.

You can find your Exercism workspace by running exercism debug and looking for the line that starts with Workspace.

For more detailed information about running tests, code style and linting, please see the help page.

Source

The Ruby Koans triangle project, parts 1 & 2 http://rubykoans.com

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

triangle_test.py

import unittest

from triangle import is_equilateral, is_isosceles, is_scalene


# Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0

class is_equilateralTests(unittest.TestCase):
    def test_true_if_all_sides_are_equal(self):
        self.assertIs(is_equilateral([2, 2, 2]), True)

    def test_false_if_any_side_is_unequal(self):
        self.assertIs(is_equilateral([2, 3, 2]), False)

    def test_false_if_no_sides_are_equal(self):
        self.assertIs(is_equilateral([5, 4, 6]), False)

    def test_false_if_all_sides_are_zero(self):
        self.assertIs(is_equilateral([0, 0, 0]), False)

    def test_sides_may_be_floats(self):
        self.assertIs(is_equilateral([0.5, 0.5, 0.5]), True)


class is_isoscelesTests(unittest.TestCase):
    def test_true_if_last_two_sides_are_equal(self):
        self.assertIs(is_isosceles([3, 4, 4]), True)

    def test_true_if_first_two_sides_are_equal(self):
        self.assertIs(is_isosceles([4, 4, 3]), True)

    def test_true_if_first_and_last_sides_are_equal(self):
        self.assertIs(is_isosceles([4, 3, 4]), True)

    def test_is_equilateral_triangles_are_also_is_isosceles(self):
        self.assertIs(is_isosceles([4, 4, 4]), True)

    def test_false_if_no_sides_are_equal(self):
        self.assertIs(is_isosceles([2, 3, 4]), False)

    def test_violation_of_triangle_inequality_not_is_isosceles(self):
        self.assertIs(is_isosceles([1, 1, 3]), False)

    def test_sides_may_be_floats(self):
        self.assertIs(is_isosceles([0.5, 0.4, 0.5]), True)


class is_scaleneTests(unittest.TestCase):
    def test_true_if_no_sides_are_equal(self):
        self.assertIs(is_scalene([5, 4, 6]), True)

    def test_false_if_all_sides_are_equal(self):
        self.assertIs(is_scalene([4, 4, 4]), False)

    def test_false_if_two_sides_are_equal(self):
        self.assertIs(is_scalene([4, 4, 3]), False)

    def test_violation_of_triangle_inequality_not_is_scalene(self):
        self.assertIs(is_scalene([7, 3, 2]), False)

    def test_sides_may_be_floats(self):
        self.assertIs(is_scalene([0.5, 0.4, 0.6]), True)


if __name__ == '__main__':
    unittest.main()
class Triangle:

    EQUILATERAL = "equilateral"
    ISOSCELES = "isosceles"
    SCALENE = "scalene"

    def __init__(self, a, b, c):
        self.a = a
        self.b = b
        self.c = c
        if self.error():
            raise TriangleError

    def kind(self):
        if self.equilateral():
            return self.EQUILATERAL
        if self.isosceles():
            return self.ISOSCELES
        return self.SCALENE

    def equilateral(self):
        return self.a == self.b == self.c

    def isosceles(self):
        return self.a == self.b or self.b == self.c or self.a == self.c

    def error(self):
        return self.negative_sides() or self.triangle_inequality()

    def negative_sides(self):
        return self.a <= 0 or self.b <= 0 or self.c <= 0

    def triangle_inequality(self):
        return (self.a + self.b <= self.c or
                self.b + self.c <= self.a or
                self.a + self.c <= self.b)


class TriangleError(Exception):
    pass

Community comments

Find this solution interesting? Ask the author a question to learn more.

What can you learn from this solution?

A huge amount can be learned from reading other peopleโ€™s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?