🎉 Exercism Research is now launched. Help Exercism, help science and have some fun at research.exercism.io 🎉
Avatar of petertseng

petertseng's solution

to Sieve in the Scala Track

Published at Jul 13 2018 · 0 comments
Instructions
Test suite
Solution

Use the Sieve of Eratosthenes to find all the primes from 2 up to a given number.

The Sieve of Eratosthenes is a simple, ancient algorithm for finding all prime numbers up to any given limit. It does so by iteratively marking as composite (i.e. not prime) the multiples of each prime, starting with the multiples of 2.

Create your range, starting at two and continuing up to and including the given limit. (i.e. [2, limit])

The algorithm consists of repeating the following over and over:

  • take the next available unmarked number in your list (it is prime)
  • mark all the multiples of that number (they are not prime)

Repeat until you have processed each number in your range.

When the algorithm terminates, all the numbers in the list that have not been marked are prime.

The wikipedia article has a useful graphic that explains the algorithm: https://en.wikipedia.org/wiki/Sieve_of_Eratosthenes

Notice that this is a very specific algorithm, and the tests don't check that you've implemented the algorithm, only that you've come up with the correct list of primes.

The Scala exercises assume an SBT project scheme. The exercise solution source should be placed within the exercise directory/src/main/scala. The exercise unit tests can be found within the exercise directory/src/test/scala.

To run the tests simply run the command sbt test in the exercise directory.

For more detailed info about the Scala track see the help page.

Source

Sieve of Eratosthenes at Wikipedia http://en.wikipedia.org/wiki/Sieve_of_Eratosthenes

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

SieveTest.scala

import org.scalatest.{Matchers, FunSuite}

/** @version 1.1.0 */
class SieveTest extends FunSuite with Matchers {

  test("no primes under two") {
    Sieve.primes(1) should be(List())
  }

  test("find first prime") {
    pending
    Sieve.primes(2) should be(List(2))
  }

  test("find primes up to 10") {
    pending
    Sieve.primes(10) should be(List(2, 3, 5, 7))
  }

  test("limit is prime") {
    pending
    Sieve.primes(13) should be(List(2, 3, 5, 7, 11, 13))
  }

  test("find primes up to 1000") {
    pending
    Sieve.primes(1000) should be(
      List(2, 3, 5, 7, 11, 13, 17, 19, 23, 29, 31, 37, 41, 43, 47, 53, 59, 61,
        67, 71, 73, 79, 83, 89, 97, 101, 103, 107, 109, 113, 127, 131, 137, 139,
        149, 151, 157, 163, 167, 173, 179, 181, 191, 193, 197, 199, 211, 223,
        227, 229, 233, 239, 241, 251, 257, 263, 269, 271, 277, 281, 283, 293,
        307, 311, 313, 317, 331, 337, 347, 349, 353, 359, 367, 373, 379, 383,
        389, 397, 401, 409, 419, 421, 431, 433, 439, 443, 449, 457, 461, 463,
        467, 479, 487, 491, 499, 503, 509, 521, 523, 541, 547, 557, 563, 569,
        571, 577, 587, 593, 599, 601, 607, 613, 617, 619, 631, 641, 643, 647,
        653, 659, 661, 673, 677, 683, 691, 701, 709, 719, 727, 733, 739, 743,
        751, 757, 761, 769, 773, 787, 797, 809, 811, 821, 823, 827, 829, 839,
        853, 857, 859, 863, 877, 881, 883, 887, 907, 911, 919, 929, 937, 941,
        947, 953, 967, 971, 977, 983, 991, 997))
  }
}
/**
 * It seems to be a widespread opinion that Akka is a very compelling reason to use Scala.
 * This obviously means we should use Akka to solve this problem.
 * To do otherwise would be a major disservice to Scala.
 */
import akka.actor.Actor
import akka.actor.ActorRef
import akka.actor.ActorSystem
import akka.actor.Props
import akka.pattern.ask
import akka.util.Timeout
import scala.collection.mutable.ArrayBuffer
import scala.concurrent.Await
import scala.concurrent.duration._

case class NumMsg(n: Int)
case class FinMsg()

class WorkerActor(sink: ActorRef) extends Actor {
  var prime: Option[Int] = None
  var next = sink

  def receive = {
    case NumMsg(n) => prime match {
      case None => {
        prime = Some(n)
        sink ! NumMsg(n)
        next = context.actorOf(Props(new WorkerActor(sink)))
      }
      case Some(p) => if (n % p != 0) {
        next ! NumMsg(n)
      }
    }
    case msg: FinMsg => next.forward(msg)
  }
}

class SinkActor extends Actor {
  val primes = ArrayBuffer[Int]()

  def receive = {
    case NumMsg(n) => primes += n
    case FinMsg() => sender ! primes.toArray
  }
}

object Sieve {
  def primesUpTo(limit: Int): Traversable[Int] = {
    val system = ActorSystem("Sieve")
    val output = system.actorOf(Props(new SinkActor()))
    val input = system.actorOf(Props(new WorkerActor(output)))

    for (i <- 2 to limit) {
      input ! NumMsg(i)
    }
    implicit val timeout = Timeout((limit * 2).seconds)
    val future = input ? FinMsg()
    val primes = Await.result(future, timeout.duration).asInstanceOf[Array[Int]]
    system.shutdown
    primes
  }
}

Community comments

Find this solution interesting? Ask the author a question to learn more.

What can you learn from this solution?

A huge amount can be learned from reading other people’s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?