Exercism v3 launches on Sept 1st 2021. Learn more! ๐Ÿš€๐Ÿš€๐Ÿš€
Avatar of rootulp

rootulp's solution

to Binary in the Python Track

Published at Jul 13 2018 · 1 comment
Instructions
Test suite
Solution

Note:

This solution was written on an old version of Exercism. The tests below might not correspond to the solution code, and the exercise may have changed since this code was written.

Convert a binary number, represented as a string (e.g. '101010'), to its decimal equivalent using first principles.

Implement binary to decimal conversion. Given a binary input string, your program should produce a decimal output. The program should handle invalid inputs.

Note

  • Implement the conversion yourself. Do not use something else to perform the conversion for you.

About Binary (Base-2)

Decimal is a base-10 system.

A number 23 in base 10 notation can be understood as a linear combination of powers of 10:

  • The rightmost digit gets multiplied by 10^0 = 1
  • The next number gets multiplied by 10^1 = 10
  • ...
  • The nth number gets multiplied by 10^(n-1).
  • All these values are summed.

So: 23 => 2*10^1 + 3*10^0 => 2*10 + 3*1 = 23 base 10

Binary is similar, but uses powers of 2 rather than powers of 10.

So: 101 => 1*2^2 + 0*2^1 + 1*2^0 => 1*4 + 0*2 + 1*1 => 4 + 1 => 5 base 10.

Exception messages

Sometimes it is necessary to raise an exception. When you do this, you should include a meaningful error message to indicate what the source of the error is. This makes your code more readable and helps significantly with debugging. Not every exercise will require you to raise an exception, but for those that do, the tests will only pass if you include a message.

To raise a message with an exception, just write it as an argument to the exception type. For example, instead of raise Exception, you should write:

raise Exception("Meaningful message indicating the source of the error")

Running the tests

To run the tests, run the appropriate command below (why they are different):

  • Python 2.7: py.test binary_test.py
  • Python 3.4+: pytest binary_test.py

Alternatively, you can tell Python to run the pytest module (allowing the same command to be used regardless of Python version): python -m pytest binary_test.py

Common pytest options

  • -v : enable verbose output
  • -x : stop running tests on first failure
  • --ff : run failures from previous test before running other test cases

For other options, see python -m pytest -h

Submitting Exercises

Note that, when trying to submit an exercise, make sure the solution is in the $EXERCISM_WORKSPACE/python/binary directory.

You can find your Exercism workspace by running exercism debug and looking for the line that starts with Workspace.

For more detailed information about running tests, code style and linting, please see the help page.

Source

All of Computer Science http://www.wolframalpha.com/input/?i=binary&a=*C.binary-_*MathWorld-

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

binary_test.py

"""Tests for the binary exercise

Implementation note:
If the argument to parse_binary isn't a valid binary number the
function should raise a ValueError with a meaningful error message.
"""
import unittest

from binary import parse_binary


class BinaryTest(unittest.TestCase):
    def test_binary_1_is_decimal_1(self):
        self.assertEqual(parse_binary("1"), 1)

    def test_binary_10_is_decimal_2(self):
        self.assertEqual(parse_binary("10"), 2)

    def test_binary_11_is_decimal_3(self):
        self.assertEqual(parse_binary("11"), 3)

    def test_binary_100_is_decimal_4(self):
        self.assertEqual(parse_binary("100"), 4)

    def test_binary_1001_is_decimal_9(self):
        self.assertEqual(parse_binary("1001"), 9)

    def test_binary_11010_is_decimal_26(self):
        self.assertEqual(parse_binary("11010"), 26)

    def test_binary_10001101000_is_decimal_1128(self):
        self.assertEqual(parse_binary("10001101000"), 1128)

    def test_invalid_binary_text_only(self):
        with self.assertRaisesWithMessage(ValueError):
            parse_binary("carrot")

    def test_invalid_binary_number_not_base2(self):
        with self.assertRaisesWithMessage(ValueError):
            parse_binary("102011")

    def test_invalid_binary_numbers_with_text(self):
        with self.assertRaisesWithMessage(ValueError):
            parse_binary("10nope")

    def test_invalid_binary_text_with_numbers(self):
        with self.assertRaisesWithMessage(ValueError):
            parse_binary("nope10")

    # Utility functions
    def setUp(self):
        try:
            self.assertRaisesRegex
        except AttributeError:
            self.assertRaisesRegex = self.assertRaisesRegexp

    def assertRaisesWithMessage(self, exception):
        return self.assertRaisesRegex(exception, r".+")


if __name__ == '__main__':
    unittest.main()
class Binary:
    VALID_CHARS = set("01")

    @classmethod
    def parse_binary(cls, inp):
        if not cls.valid(inp):
            raise ValueError
        return cls.convert_to_decimal(inp)

    @classmethod
    def convert_to_decimal(cls, inp):
        return sum([2**idx for idx, val in enumerate(reversed(inp))
                    if val == "1"])

    @classmethod
    def valid(cls, inp):
        return set(inp) <= cls.VALID_CHARS


def parse_binary(inp):
    return Binary.parse_binary(inp)

Community comments

Find this solution interesting? Ask the author a question to learn more.
Avatar of ozan

Fine strategy over all but why the class with three class methods?

What can you learn from this solution?

A huge amount can be learned from reading other peopleโ€™s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?