Avatar of fsouza

fsouza's solution

to Luhn in the OCaml Track

Published at Jul 08 2019 · 0 comments
Instructions
Test suite
Solution

Note:

This exercise has changed since this solution was written.

Given a number determine whether or not it is valid per the Luhn formula.

The Luhn algorithm is a simple checksum formula used to validate a variety of identification numbers, such as credit card numbers and Canadian Social Insurance Numbers.

The task is to check if a given string is valid.

Validating a Number

Strings of length 1 or less are not valid. Spaces are allowed in the input, but they should be stripped before checking. All other non-digit characters are disallowed.

Example 1: valid credit card number

4539 1488 0343 6467

The first step of the Luhn algorithm is to double every second digit, starting from the right. We will be doubling

4_3_ 1_8_ 0_4_ 6_6_

If doubling the number results in a number greater than 9 then subtract 9 from the product. The results of our doubling:

8569 2478 0383 3437

Then sum all of the digits:

8+5+6+9+2+4+7+8+0+3+8+3+3+4+3+7 = 80

If the sum is evenly divisible by 10, then the number is valid. This number is valid!

Example 2: invalid credit card number

8273 1232 7352 0569

Double the second digits, starting from the right

7253 2262 5312 0539

Sum the digits

7+2+5+3+2+2+6+2+5+3+1+2+0+5+3+9 = 57

57 is not evenly divisible by 10, so this number is not valid.

Getting Started

  1. Install the Exercism CLI.

  2. Install OCaml.

  3. For library documentation, follow Useful OCaml resources.

Running Tests

A Makefile is provided with a default target to compile your solution and run the tests. At the command line, type:

make

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

Feedback, Issues, Pull Requests

The exercism/ocaml repository on GitHub is the home for all of the Ocaml exercises.

If you have feedback about an exercise, or want to help implementing a new one, head over there and create an issue or submit a PR. We welcome new contributors!

Source

The Luhn Algorithm on Wikipedia http://en.wikipedia.org/wiki/Luhn_algorithm

test.ml

open Base
open OUnit2
open Luhn

let assert_valid expected input _test_ctxt = 
  assert_equal ~printer:Bool.to_string expected (valid input)

let tests = [
  "single digit strings can not be valid" >::
    assert_valid false "1";
  "a single zero is invalid" >::
    assert_valid false "0";
  "a simple valid SIN that remains valid if reversed" >::
    assert_valid true "059";
  "a simple valid SIN that becomes invalid if reversed" >::
    assert_valid true "59";
  "a valid Canadian SIN" >::
    assert_valid true "055 444 285";
  "invalid Canadian SIN" >::
    assert_valid false "055 444 286";
  "invalid credit card" >::
    assert_valid false "8273 1232 7352 0569";
  "valid number with an even number of digits" >::
    assert_valid true "095 245 88";
  "valid number with an odd number of spaces" >::
    assert_valid true "234 567 891 234";
  "valid strings with a non-digit added at the end become invalid" >::
    assert_valid false "059a";
  "valid strings with punctuation included become invalid" >::
    assert_valid false "055-444-285";
  "valid strings with symbols included become invalid" >::
    assert_valid false "055# 444$ 285";
  "single zero with space is invalid" >::
    assert_valid false " 0";
  "more than a single zero is valid" >::
    assert_valid true "0000 0";
  "input digit 9 is correctly converted to output digit 9" >::
    assert_valid true "091";
  "using ascii value for non-doubled non-digit isn't allowed" >::
    assert_valid false "055b 444 285";
  "using ascii value for doubled non-digit isn't allowed" >::
    assert_valid false ":9";
]

let () =
  run_test_tt_main ("luhn tests" >::: tests)

luhn.ml

open Base
open Option.Monad_infix

let double n =
  let doubled = n * 2 in
  if doubled > 9 then doubled - 9 else doubled

let handle_digit i n = if i % 2 = 1 then double n else n

let rec option_list_to_list_option_rev acc = function
  | [] ->
      Some acc
  | None :: _ ->
      None
  | Some v :: tl ->
      option_list_to_list_option_rev (v :: acc) tl

let valid ccnum =
  ccnum |> String.to_list
  |> List.filter ~f:(Fn.non (Char.equal ' '))
  |> List.map ~f:Char.get_digit
  |> option_list_to_list_option_rev []
  >>= (fun l -> Option.some_if (List.length l > 1) l)
  >>| (fun l -> List.mapi l ~f:handle_digit)
  >>| (fun l -> List.sum (module Int) l ~f:Fn.id)
  >>| (fun sum -> sum % 10 = 0)
  |> Option.value ~default:false

luhn.mli

(* Returns true if the input is a valid Luhn string *)
val valid : string -> bool

Community comments

Find this solution interesting? Ask the author a question to learn more.

What can you learn from this solution?

A huge amount can be learned from reading other people’s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?