# 4d47's solution

## to Simple Cipher (Legacy) in the JavaScript Track

Published at Jul 13 2018 · 1 comment
Instructions
Test suite
Solution

#### Note:

This solution was written on an old version of Exercism. The tests below might not correspond to the solution code, and the exercise may have changed since this code was written.

# Simple Cipher

Implement a simple shift cipher like Caesar and a more secure substitution cipher.

## Step 1

"If he had anything confidential to say, he wrote it in cipher, that is, by so changing the order of the letters of the alphabet, that not a word could be made out. If anyone wishes to decipher these, and get at their meaning, he must substitute the fourth letter of the alphabet, namely D, for A, and so with the others." —Suetonius, Life of Julius Caesar

Ciphers are very straight-forward algorithms that allow us to render text less readable while still allowing easy deciphering. They are vulnerable to many forms of cryptoanalysis, but we are lucky that generally our little sisters are not cryptoanalysts.

The Caesar Cipher was used for some messages from Julius Caesar that were sent afield. Now Caesar knew that the cipher wasn't very good, but he had one ally in that respect: almost nobody could read well. So even being a couple letters off was sufficient so that people couldn't recognize the few words that they did know.

Your task is to create a simple shift cipher like the Caesar Cipher. This image is a great example of the Caesar Cipher:

For example:

Giving "iamapandabear" as input to the encode function returns the cipher "ldpdsdqgdehdu". Obscure enough to keep our message secret in transit.

When "ldpdsdqgdehdu" is put into the decode function it would return the original "iamapandabear" letting your friend read your original message.

## Step 2

Shift ciphers are no fun though when your kid sister figures it out. Try amending the code to allow us to specify a key and use that for the shift distance. This is called a substitution cipher.

Here's an example:

Given the key "aaaaaaaaaaaaaaaaaa", encoding the string "iamapandabear" would return the original "iamapandabear".

Given the key "ddddddddddddddddd", encoding our string "iamapandabear" would return the obscured "ldpdsdqgdehdu"

In the example above, we've set a = 0 for the key value. So when the plaintext is added to the key, we end up with the same message coming out. So "aaaa" is not an ideal key. But if we set the key to "dddd", we would get the same thing as the Caesar Cipher.

## Step 3

The weakest link in any cipher is the human being. Let's make your substitution cipher a little more fault tolerant by providing a source of randomness and ensuring that the key contains only lowercase letters.

If someone doesn't submit a key at all, generate a truly random key of at least 100 characters in length.

If the key submitted is not composed only of lowercase letters, your solution should handle the error in a language-appropriate way.

## Extensions

Shift ciphers work by making the text slightly odd, but are vulnerable to frequency analysis. Substitution ciphers help that, but are still very vulnerable when the key is short or if spaces are preserved. Later on you'll see one solution to this problem in the exercise "crypto-square".

If you want to go farther in this field, the questions begin to be about how we can exchange keys in a secure way. Take a look at Diffie-Hellman on Wikipedia for one of the first implementations of this scheme.

## Setup

Go through the setup instructions for Javascript to install the necessary dependencies:

https://exercism.io/tracks/javascript/installation

## Requirements

Install assignment dependencies:

``````\$ npm install
``````

## Making the test suite pass

Execute the tests with:

``````\$ npm test
``````

In the test suites all tests but the first have been skipped.

Once you get a test passing, you can enable the next one by changing `xtest` to `test`.

## Source

Substitution Cipher at Wikipedia http://en.wikipedia.org/wiki/Substitution_cipher

## Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

### simple-cipher.spec.js

``````import { Cipher } from './simple-cipher';

describe('Random key generation', () => {
xtest('generates keys at random', () => {
// Strictly speaking, this is difficult to test with 100% certainty.
// But, if you have a generator that generates 100-character-long
// strings of lowercase letters at random, the odds of two consecutively
// generated keys being identical are astronomically low.
expect(new Cipher().key).not.toEqual(new Cipher().key);
});
});

describe('Random key cipher', () => {
const cipher = new Cipher();

test('has a key made of letters', () => {
expect(cipher.key).toMatch(/^[a-z]+\$/);
});

xtest('has a key that is at least 100 characters long', () => {
expect(cipher.key.length).toBeGreaterThanOrEqual(100);
});

// Here we take advantage of the fact that plaintext of "aaa..."
// outputs the key. This is a critical problem with shift ciphers, some
// characters will always output the key verbatim.
xtest('can encode', () => {
expect(cipher.encode('aaaaaaaaaa')).toEqual(cipher.key.substr(0, 10));
});

xtest('can decode', () => {
expect(cipher.decode(cipher.key.substr(0, 10))).toEqual('aaaaaaaaaa');
});

xtest('is reversible', () => {
const plaintext = 'abcdefghij';
expect(cipher.decode(cipher.encode(plaintext))).toEqual(plaintext);
});
});

describe('Incorrect key cipher', () => {
xtest('throws an error with an all caps key', () => {
expect(() => {
new Cipher('ABCDEF');
});

xtest('throws an error with a numeric key', () => {
expect(() => {
new Cipher('12345');
});

xtest('throws an error with an empty key', () => {
expect(() => {
new Cipher('');
});

xtest('throws an error with a leading space', () => {
expect(() => {
});

xtest('throws an error with a punctuation mark', () => {
expect(() => {
new Cipher('hyphened-word');
});

xtest('throws an error with a single capital letter', () => {
expect(() => {
new Cipher('leonardoDavinci');
});
});

describe('Substitution cipher', () => {
const key = 'abcdefghij';
const cipher = new Cipher(key);

xtest('keeps the submitted key', () => {
expect(cipher.key).toEqual(key);
});

xtest('can encode', () => {
expect(cipher.encode('aaaaaaaaaa')).toEqual('abcdefghij');
});

xtest('can decode', () => {
expect(cipher.decode('abcdefghij')).toEqual('aaaaaaaaaa');
});

xtest('is reversible', () => {
expect(cipher.decode(cipher.encode('abcdefghij'))).toEqual('abcdefghij');
});

xtest(': double shift encode', () => {
expect(new Cipher('iamapandabear').encode('iamapandabear'))
.toEqual('qayaeaagaciai');
});

xtest('can wrap on encode', () => {
expect(cipher.encode('zzzzzzzzzz')).toEqual('zabcdefghi');
});

xtest('can wrap on decode', () => {
expect(cipher.decode('zabcdefghi')).toEqual('zzzzzzzzzz');
});

xtest('can handle messages longer than the key', function() {
expect(new Cipher('abc').encode('iamapandabear'))
.toEqual('iboaqcnecbfcr');
});
});``````
``````module.exports =

class Cipher {

constructor(key) {
if (!/^[a-z]+\$/.test(key)) {
}
this.key = key || Array.apply(null, Array(126)).map(_ => this.pickChar()).join('')
}

encode(s) {
return this.shift(s, +1)
}

decode(s) {
return this.shift(s, -1)
}

// private

shift(s, direction) {
var i, p, k, e, result = ''
for (i = 0; i < s.length; i++) {
p = this.toCode(s[i])
k = this.toCode(this.key[ i % this.key.length ])
e = p + k * direction
e = e < 0 ? 26 - Math.abs(e) : e % 26
result += this.fromCode(e)
}
return result
}

toCode(s) {
return s.charCodeAt(0) - 97
}

fromCode(c) {
return String.fromCharCode(c + 97)
}

pickChar() {
return this.fromCode( Math.floor(Math.random() * 26) )
}
}``````

Solution Author
commented 310 days ago

Reading again I'm stumped this test(key) pass the tests, turns out RegExp.test undefined argument match against "undefined". Lesson learned: don't let the greenness of tests blind you. > /^[a-z]+\$/.test(undefined) true

### What can you learn from this solution?

A huge amount can be learned from reading other people’s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

• What compromises have been made?