Avatar of Abd-K

Abd-K's solution

to Book Store in the Java Track

Published at Jul 13 2018 · 3 comments
Instructions
Test suite
Solution

Note:

This solution was written on an old version of Exercism. The tests below might not correspond to the solution code, and the exercise may have changed since this code was written.

To try and encourage more sales of different books from a popular 5 book series, a bookshop has decided to offer discounts on multiple book purchases.

One copy of any of the five books costs $8.

If, however, you buy two different books, you get a 5% discount on those two books.

If you buy 3 different books, you get a 10% discount.

If you buy 4 different books, you get a 20% discount.

If you buy all 5, you get a 25% discount.

Note: that if you buy four books, of which 3 are different titles, you get a 10% discount on the 3 that form part of a set, but the fourth book still costs $8.

Your mission is to write a piece of code to calculate the price of any conceivable shopping basket (containing only books of the same series), giving as big a discount as possible.

For example, how much does this basket of books cost?

  • 2 copies of the first book
  • 2 copies of the second book
  • 2 copies of the third book
  • 1 copy of the fourth book
  • 1 copy of the fifth book

One way of grouping these 8 books is:

  • 1 group of 5 --> 25% discount (1st,2nd,3rd,4th,5th)
  • +1 group of 3 --> 10% discount (1st,2nd,3rd)

This would give a total of:

  • 5 books at a 25% discount
  • +3 books at a 10% discount

Resulting in:

  • 5 x (8 - 2.00) == 5 x 6.00 == $30.00
  • +3 x (8 - 0.80) == 3 x 7.20 == $21.60

For a total of $51.60

However, a different way to group these 8 books is:

  • 1 group of 4 books --> 20% discount (1st,2nd,3rd,4th)
  • +1 group of 4 books --> 20% discount (1st,2nd,3rd,5th)

This would give a total of:

  • 4 books at a 20% discount
  • +4 books at a 20% discount

Resulting in:

  • 4 x (8 - 1.60) == 4 x 6.40 == $25.60
  • +4 x (8 - 1.60) == 4 x 6.40 == $25.60

For a total of $51.20

And $51.20 is the price with the biggest discount.

Running the tests

You can run all the tests for an exercise by entering

$ gradle test

in your terminal.

Source

Inspired by the harry potter kata from Cyber-Dojo. http://cyber-dojo.org

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

BookStoreTest.java

import static org.junit.Assert.assertEquals;

import java.util.Collections;
import java.util.List;
import java.util.Arrays;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

public class BookStoreTest {

  // This is sufficient accuracy since we're handling currency values, which should be equal to within 2 decimal places.
  private static final double EQUALITY_TOLERANCE = 0.001;

  private BookStore bookStore;

  @Before
  public void setUp() {
    bookStore = new BookStore();
  }

  @Test
  public void onlyASingleBook() {
    List<Integer> books = Collections.singletonList(1);
    assertEquals(8.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void twoOfSameBook() {
    List<Integer> books = Arrays.asList(2, 2);
    assertEquals(16.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void emptyBasket() {
    List<Integer> books = Collections.emptyList();
    assertEquals(0.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void twoDifferentBooks() {
    List<Integer> books = Arrays.asList(1, 2);
    assertEquals(15.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void threeDifferentBooks() {
    List<Integer> books = Arrays.asList(1, 2, 3);
    assertEquals(21.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void fourDifferentBooks() {
    List<Integer> books = Arrays.asList(1, 2, 3, 4);
    assertEquals(25.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void fiveDifferentBooks() {
    List<Integer> books = Arrays.asList(1, 2, 3, 4, 5);
    assertEquals(30.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void twoGroupsOfFourIsCheaperThanGroupOfFivePlusGroupOfThree() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 5);
    assertEquals(51.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void groupOfFourPlusGroupOfTwoIsCheaperThanTwoGroupsOfThree() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 4);
    assertEquals(40.80, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void twoEachOfFirst4BooksAnd1CopyEachOfRest() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5);
    assertEquals(55.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void twoCopiesOfEachBook() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5);
    assertEquals(60.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void threeCopiesOfFirstBookAnd2EachOfRemaining() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 1);
    assertEquals(68.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void threeEachOFirst2BooksAnd2EachOfRemainingBooks() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 1, 2);
    assertEquals(75.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

  @Ignore("Remove to run test")
  @Test
  public void fourGroupsOfFourAreCheaperThanTwoGroupsEachOfFiveAndThree() {
    List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 5, 1, 1, 2, 2, 3, 3, 4, 5);
    assertEquals(102.4, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
  }

}
import java.util.HashMap;
import java.util.List;
import java.util.Map;

public class BookStore {
    private final static int bookPrice = 8;
    private double finalCost;
    Map<Integer, Integer> basketBooksList = new HashMap<Integer, Integer>();

    public double calculateBasketCost(List<Integer> books) {
        countBooksInBasket(books);
        applyDiscountToBasket( 0);
        return finalCost;
    }

    //recursive function
    private void applyDiscountToBasket(double cost) {
        //loop till 0
        if(basketBooksList.size() == 0) {
            finalCost = cost;
        } else {
            //count num of books left
            int bookSetSize = basketBooksList.size();
            applyDiscountToBasket(calculateCost(cost, getDiscountFactor(bookSetSize), bookSetSize));
        }
    }

    private double calculateCost(double cost, int discountFactor, int bookSetSize) {
        removeDiscountedBooksFromBasket();
        return cost + (bookSetSize * bookPrice * (1.00-discountFactor/100.00));
    }

    //deduct one from all
    private void removeDiscountedBooksFromBasket() {
        basketBooksList.entrySet().forEach(entry -> basketBooksList.put(entry.getKey(), entry.getValue()-1));
        basketBooksList.entrySet().removeIf(entry -> entry.getValue().equals(0));
    }

    //apply discount by num of books left
    private int getDiscountFactor(int bookSetSize) {
        switch(bookSetSize) {
            case 2:
                return 5;
            case 3:
                return 10;
            case 4:
                return 20;
            case 5:
                return 25;
            default:
                return 0;
        }
    }

    //fill basket with count for each book
    private void countBooksInBasket(List<Integer> books) {
        for (Integer book: books) {
            if(basketBooksList.containsKey(book)) {
                basketBooksList.put(book, Integer.valueOf(basketBooksList.get(book)+1));
            } else {
                basketBooksList.put(book, 1);
            }
        }
    }
}

Community comments

Find this solution interesting? Ask the author a question to learn more.
Avatar of Abd-K
Abd-K
Solution Author
commented over 2 years ago

All test cases are passing except for "twoGroupsOfFourIsCheaperThanGroupOfFivePlusGroupOfThree". i am almost certain the expected value for the test case is incorrect and should be "51.6", please correct me if otherwise

Avatar of RupzKoomar

Same here :) I calculated the value myself and I am also getting 51.6 . But other's codes are working for all the tests. So I think we are getting something wrong.

Avatar of Abd-K
Abd-K
Solution Author
commented over 2 years ago

@RupzKoomar commented:

Same here :) I calculated the value myself and I am also getting 51.6 . But other's codes are working for all the tests. So I think we are getting something wrong.

haha atleast i am not alone on this

What can you learn from this solution?

A huge amount can be learned from reading other people’s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?