Avatar of jdvr

jdvr's solution

to Book Store in the Java Track

Published at Aug 27 2019 · 1 comment
Instructions
Test suite
Solution

To try and encourage more sales of different books from a popular 5 book series, a bookshop has decided to offer discounts on multiple book purchases.

One copy of any of the five books costs $8.

If, however, you buy two different books, you get a 5% discount on those two books.

If you buy 3 different books, you get a 10% discount.

If you buy 4 different books, you get a 20% discount.

If you buy all 5, you get a 25% discount.

Note: that if you buy four books, of which 3 are different titles, you get a 10% discount on the 3 that form part of a set, but the fourth book still costs $8.

Your mission is to write a piece of code to calculate the price of any conceivable shopping basket (containing only books of the same series), giving as big a discount as possible.

For example, how much does this basket of books cost?

  • 2 copies of the first book
  • 2 copies of the second book
  • 2 copies of the third book
  • 1 copy of the fourth book
  • 1 copy of the fifth book

One way of grouping these 8 books is:

  • 1 group of 5 --> 25% discount (1st,2nd,3rd,4th,5th)
  • +1 group of 3 --> 10% discount (1st,2nd,3rd)

This would give a total of:

  • 5 books at a 25% discount
  • +3 books at a 10% discount

Resulting in:

  • 5 x (8 - 2.00) == 5 x 6.00 == $30.00
  • +3 x (8 - 0.80) == 3 x 7.20 == $21.60

For a total of $51.60

However, a different way to group these 8 books is:

  • 1 group of 4 books --> 20% discount (1st,2nd,3rd,4th)
  • +1 group of 4 books --> 20% discount (1st,2nd,3rd,5th)

This would give a total of:

  • 4 books at a 20% discount
  • +4 books at a 20% discount

Resulting in:

  • 4 x (8 - 1.60) == 4 x 6.40 == $25.60
  • +4 x (8 - 1.60) == 4 x 6.40 == $25.60

For a total of $51.20

And $51.20 is the price with the biggest discount.

Setup

Go through the setup instructions for Java to install the necessary dependencies:

https://exercism.io/tracks/java/installation

Running the tests

You can run all the tests for an exercise by entering the following in your terminal:

$ gradle test

Use gradlew.bat if you're on Windows

In the test suites all tests but the first have been skipped.

Once you get a test passing, you can enable the next one by removing the @Ignore("Remove to run test") annotation.

Source

Inspired by the harry potter kata from Cyber-Dojo. http://cyber-dojo.org

Submitting Incomplete Solutions

It's possible to submit an incomplete solution so you can see how others have completed the exercise.

BookStoreTest.java

import static org.junit.Assert.assertEquals;

import java.util.Collections;
import java.util.List;
import java.util.Arrays;

import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

public class BookStoreTest {

    // This is sufficient accuracy since we're handling currency values, which should be equal
    // to within 2 decimal places.
    private static final double EQUALITY_TOLERANCE = 0.001;

    private BookStore bookStore;

    @Before
    public void setUp() {
        bookStore = new BookStore();
    }

    @Test
    public void onlyASingleBook() {
        List<Integer> books = Collections.singletonList(1);
        assertEquals(8.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoOfSameBook() {
        List<Integer> books = Arrays.asList(2, 2);
        assertEquals(16.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void emptyBasket() {
        List<Integer> books = Collections.emptyList();
        assertEquals(0.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoDifferentBooks() {
        List<Integer> books = Arrays.asList(1, 2);
        assertEquals(15.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void threeDifferentBooks() {
        List<Integer> books = Arrays.asList(1, 2, 3);
        assertEquals(21.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void fourDifferentBooks() {
        List<Integer> books = Arrays.asList(1, 2, 3, 4);
        assertEquals(25.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void fiveDifferentBooks() {
        List<Integer> books = Arrays.asList(1, 2, 3, 4, 5);
        assertEquals(30.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoGroupsOfFourIsCheaperThanGroupOfFivePlusGroupOfThree() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 5);
        assertEquals(51.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoGroupsOfFourIsCheaperThanGroupsOfFiveAndThree() {
        List<Integer> books = Arrays.asList(1, 1, 2, 3, 4, 4, 5, 5);
        assertEquals(51.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void groupOfFourPlusGroupOfTwoIsCheaperThanTwoGroupsOfThree() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 4);
        assertEquals(40.80, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoEachOfFirst4BooksAnd1CopyEachOfRest() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5);
        assertEquals(55.60, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void twoCopiesOfEachBook() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5);
        assertEquals(60.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void threeCopiesOfFirstBookAnd2EachOfRemaining() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 1);
        assertEquals(68.00, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void threeEachOFirst2BooksAnd2EachOfRemainingBooks() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 4, 5, 5, 1, 2);
        assertEquals(75.20, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }

    @Ignore("Remove to run test")
    @Test
    public void fourGroupsOfFourAreCheaperThanTwoGroupsEachOfFiveAndThree() {
        List<Integer> books = Arrays.asList(1, 1, 2, 2, 3, 3, 4, 5, 1, 1, 2, 2, 3, 3, 4, 5);
        assertEquals(102.4, bookStore.calculateBasketCost(books), EQUALITY_TOLERANCE);
    }
}
package jdvr;

import java.util.ArrayList;
import java.util.List;
import java.util.function.Function;
import java.util.stream.Collectors;
import java.util.stream.IntStream;

import static java.util.stream.Collectors.toList;

public class BookStore {

	private static final int BasePrice = 8;

	private static final double[] DiscountByGroupSize = {0, 0, .05, .1, .2, .25};

	public double calculateBasketCost(final List<Integer> books) {
		var numberCount = books.stream().collect(Collectors.groupingBy(Function.identity(), Collectors.counting()));

		List<Integer> reorderedBooks = books.stream()
				.sorted((bookNumberOne, bookNumberTwo) ->
						(int) (numberCount.get(bookNumberTwo) - numberCount.get(bookNumberOne)))
				.collect(toList());
		return calculateCostGroupingBySize(reorderedBooks, 0);
	}

	private double calculateCostGroupingBySize(final List<Integer> books, final double accumulated) {
		if (books.size() == 0) {
			return accumulated;
		}

		List<Integer> availableBookNumbers = books.stream()
				.distinct()
				.collect(toList());

		return IntStream.range(0, availableBookNumbers.size())
				.mapToDouble(index -> {
					// piece of code extracted from exercims github (I dont find the correct link now)
					var uniqueAvailableGroup = availableBookNumbers.subList(0, index + 1);
					var restOfBooks = new ArrayList<>(books);
					// bulk remove will remove all elements that match, I want to remove the first
					uniqueAvailableGroup.forEach(restOfBooks::remove);

					return calculateCostGroupingBySize(
							restOfBooks,
							accumulated + priceOf(uniqueAvailableGroup.size())
					);
				})
				.min()
				.orElse(0d);
	}

	private double priceOf(int groupSize) {
		var groupPrice = BasePrice * groupSize;
		return  groupPrice - groupPrice * DiscountByGroupSize[groupSize];
	}

}

Community comments

Find this solution interesting? Ask the author a question to learn more.
Avatar of jdvr
Solution Author
commented 87 days ago

I mange to discover that I need a recursive solution to split list in different groups that may be cheaper.

I finally end up googling the way of splitting books into two list because I always have a red test.

What can you learn from this solution?

A huge amount can be learned from reading other people’s code. This is why we wanted to give exercism users the option of making their solutions public.

Here are some questions to help you reflect on this solution and learn the most from it.

  • What compromises have been made?
  • Are there new concepts here that you could read more about to improve your understanding?